metrics: export meta backup metrics #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4480 +/- ##
==========================================
- Coverage 55.37% 55.34% -0.03%
==========================================
Files 157 157
Lines 41207 41222 +15
==========================================
- Hits 22819 22816 -3
- Misses 15859 15881 +22
+ Partials 2529 2525 -4 ☔ View full report in Codecov by Sentry. |
davies
reviewed
Mar 11, 2024
davies
reviewed
Mar 11, 2024
davies
reviewed
Mar 11, 2024
polyrabbit
reviewed
Mar 11, 2024
| logger.Infof("backup metadata succeed, used %s", time.Since(now)) | ||
| } else { | ||
| logger.Warnf("backup metadata failed: %s", err) | ||
| } | ||
| LastBackupDurationG.Set(time.Since(now).Seconds()) |
There was a problem hiding this comment.
Can we have a label to indicate success/failure?
There was a problem hiding this comment.
We can know that when last_sucessfull_backup is not updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4454